[{"data":1,"prerenderedAt":-1},["ShallowReactive",2],{"skill:01M7F0C3AZT3FSYY70WBHJZZD9":3,"skill-same:01M7F0C3AZT3FSYY70WBHJZZD9":46},{"skillNo":4,"name":5,"nameZh":6,"description":7,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":16,"categories":17,"keywords":18,"publishedAt":19,"linkOnly":20,"markdownContent":21,"markdownBody":22,"frontMatter":23,"refName":24,"commitSha":25,"skillDirectory":26,"forksCount":27,"repositoryHtmlUrl":28,"repositoryHomepageUrl":6,"ownerHtmlUrl":29,"ownerBlogUrl":6,"ownerDescription":30,"updatedAt":31,"install":32,"resources":45},"01M7F0C3AZT3FSYY70WBHJZZD9","code-review",null,"Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue\u002Fspec asked for?). Runs both reviews in parallel read-only `code-reviewer` sub-agents through the configured review route and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \"review since X\".","nredd\u002Fpi-harness","nredd","https:\u002F\u002Favatars.githubusercontent.com\u002Fu\u002F13305966?v=4","01M7F0BM37W1RA8H414NPR8DA2","Nicholas Redd","01M7F0BM3WAMMSDBJPB1AM308V",2,"MIT","https:\u002F\u002Fgithub.com\u002Fnredd\u002Fpi-harness\u002Fblob\u002Fmain\u002Fpackages\u002Fpreset\u002Fskills\u002Fcode-review\u002FSKILL.md",[],[],"2026-11-16 10:05:34",false,"---\nname: code-review\ndescription: \"Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue\u002Fspec asked for?). Runs both reviews in parallel read-only `code-reviewer` sub-agents through the configured review route and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \\\"review since X\\\".\"\n---\n\nTwo-axis review of the diff between `HEAD` and a fixed point the user supplies:\n\n- **Standards**: does the code conform to this repo's documented coding standards?\n- **Spec**: does the code faithfully implement the originating issue \u002F spec?\n\nBoth axes run as **parallel `code-reviewer` sub-agents** (read-only, fixed output template; defined by the `code-reviewer` agent) so they don't pollute each other's context, then this skill aggregates their findings.\n\nThe issue tracker should have been provided to you. If `docs\u002Fagents\u002Fissue-tracker.md` is missing, tell the user to run `\u002Fsetup-matt-pocock-skills`.\n\n## Process\n\n### 1. Pin the fixed point\n\nWhatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it.\n\nResolve the fixed point and capture the final full reviewed HEAD SHA before dispatch: `git rev-parse \u003Cfixed-point>` and `git rev-parse HEAD`. For a non-PR review, use the resolved fixed point as `\u003Creviewed-base>`. For a PR, run `git merge-base \u003Cpr-base> HEAD` once, record its full SHA as `\u003Creviewed-base>`, and preserve it across every later HEAD change. Bind the diff command to those immutable values: `git diff \u003Creviewed-base>...\u003Creviewed-head>` (three-dot, so the comparison is against the original merge-base). Also note the matching commits via `git log \u003Creviewed-base>..\u003Creviewed-head> --oneline`.\n\nBefore going further, confirm the fixed point resolves and the diff is non-empty. A bad ref or empty diff should fail here, not inside two parallel sub-agents. Before aggregating, resolve `HEAD` again; if it differs from `\u003Creviewed-head>`, discard both reports and restart from this step with the preserved `\u003Creviewed-base>`. A corrective-delta review is supplemental only and never replaces either required whole-PR axis.\n\n### 2. Identify the spec source\n\nLook for the originating spec, in this order:\n\n1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in `docs\u002Fagents\u002Fissue-tracker.md`.\n2. A path the user passed as an argument.\n3. A spec file under `docs\u002F`, `specs\u002F`, or `.scratch\u002F` matching the branch name or feature.\n4. If nothing is found, ask the user where the spec is. If they confirm there is none, record that verified absence and still invoke the **Spec** sub-agent.\n\n### 3. Identify the standards sources\n\nAnything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`.\n\nOn top of whatever the repo documents, the Standards axis always carries the **smell baseline** below: a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:\n\n- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.\n- **Always a judgement call.** Each smell is a labelled heuristic (\"possible Feature Envy\"), never a hard violation. Like any standard here, skip anything tooling already enforces.\n\nEach smell reads *what it is* → *how to fix*; match it against the diff:\n\n- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.\n- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.\n- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies.\n- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.\n- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.\n- **Repeated Switches**: the same `switch`\u002F`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.\n- **Shotgun Surgery**: one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.\n- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for one reason.\n- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.\n- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.\n- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct.\n- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.\n\n### 4. Spawn both sub-agents in parallel\n\nA top-level parent spawns two `Agent` calls in one message, both `subagent_type: \"code-reviewer\"`, `run_in_background: true`, and no `model` override. A delegated session omits `run_in_background`, uses the supported blocking calls, and consumes both inline results before returning. The configured `agentModels` route selects the reviewer model. The agent is read-only and already carries the output template, the hard\u002Fjudgement rule and the word cap: do NOT restate them. Each prompt names its axis and supplies only the axis material. If the review route is quota-parked, wait; do not silently substitute a model.\n\n**Standards prompt** (`Axis: Standards`) includes:\n\n- The full original reviewed-base SHA, full reviewed HEAD SHA, and immutable whole-PR diff command and commit list bound to both.\n- The list of standards-source files you found in step 3, **plus the smell baseline from step 3** pasted in full (the sub-agent has no other access to it).\n\n**Spec prompt** (`Axis: Spec`) includes:\n\n- The full original reviewed-base SHA, full reviewed HEAD SHA, and immutable whole-PR diff command and commit list bound to both.\n- The path or fetched contents of the spec, with line numbers so findings can quote them.\n\nAlways invoke the Spec sub-agent. When absence is verified in step 2, explicitly supply \"No spec available.\" and the full reviewed HEAD so it returns the authentic SHA-bound no-spec skeleton. An unlocated spec without confirmation is not verified absence; ask before dispatch. A delegated worker asks its parent for that confirmation rather than claiming absence.\n\nIf a sub-agent returns something that does not match the template (including a bare verdict with no `Checked:` list), report it verbatim under its axis, say so, and re-run that axis; do not reformat or re-derive findings.\n\n### 5. Aggregate\n\nPresent the two reports under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_).\n\nEnd with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent.\n\n## Why two axes\n\nA change can pass one axis and fail the other:\n\n- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**\n- Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.**\n\nReporting them separately stops one axis from masking the other.\n","Two-axis review of the diff between `HEAD` and a fixed point the user supplies:\n\n- **Standards**: does the code conform to this repo's documented coding standards?\n- **Spec**: does the code faithfully implement the originating issue \u002F spec?\n\nBoth axes run as **parallel `code-reviewer` sub-agents** (read-only, fixed output template; defined by the `code-reviewer` agent) so they don't pollute each other's context, then this skill aggregates their findings.\n\nThe issue tracker should have been provided to you. If `docs\u002Fagents\u002Fissue-tracker.md` is missing, tell the user to run `\u002Fsetup-matt-pocock-skills`.\n\n## Process\n\n### 1. Pin the fixed point\n\nWhatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it.\n\nResolve the fixed point and capture the final full reviewed HEAD SHA before dispatch: `git rev-parse \u003Cfixed-point>` and `git rev-parse HEAD`. For a non-PR review, use the resolved fixed point as `\u003Creviewed-base>`. For a PR, run `git merge-base \u003Cpr-base> HEAD` once, record its full SHA as `\u003Creviewed-base>`, and preserve it across every later HEAD change. Bind the diff command to those immutable values: `git diff \u003Creviewed-base>...\u003Creviewed-head>` (three-dot, so the comparison is against the original merge-base). Also note the matching commits via `git log \u003Creviewed-base>..\u003Creviewed-head> --oneline`.\n\nBefore going further, confirm the fixed point resolves and the diff is non-empty. A bad ref or empty diff should fail here, not inside two parallel sub-agents. Before aggregating, resolve `HEAD` again; if it differs from `\u003Creviewed-head>`, discard both reports and restart from this step with the preserved `\u003Creviewed-base>`. A corrective-delta review is supplemental only and never replaces either required whole-PR axis.\n\n### 2. Identify the spec source\n\nLook for the originating spec, in this order:\n\n1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in `docs\u002Fagents\u002Fissue-tracker.md`.\n2. A path the user passed as an argument.\n3. A spec file under `docs\u002F`, `specs\u002F`, or `.scratch\u002F` matching the branch name or feature.\n4. If nothing is found, ask the user where the spec is. If they confirm there is none, record that verified absence and still invoke the **Spec** sub-agent.\n\n### 3. Identify the standards sources\n\nAnything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`.\n\nOn top of whatever the repo documents, the Standards axis always carries the **smell baseline** below: a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:\n\n- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.\n- **Always a judgement call.** Each smell is a labelled heuristic (\"possible Feature Envy\"), never a hard violation. Like any standard here, skip anything tooling already enforces.\n\nEach smell reads *what it is* → *how to fix*; match it against the diff:\n\n- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.\n- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.\n- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies.\n- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.\n- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.\n- **Repeated Switches**: the same `switch`\u002F`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.\n- **Shotgun Surgery**: one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.\n- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for one reason.\n- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.\n- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.\n- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct.\n- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.\n\n### 4. Spawn both sub-agents in parallel\n\nA top-level parent spawns two `Agent` calls in one message, both `subagent_type: \"code-reviewer\"`, `run_in_background: true`, and no `model` override. A delegated session omits `run_in_background`, uses the supported blocking calls, and consumes both inline results before returning. The configured `agentModels` route selects the reviewer model. The agent is read-only and already carries the output template, the hard\u002Fjudgement rule and the word cap: do NOT restate them. Each prompt names its axis and supplies only the axis material. If the review route is quota-parked, wait; do not silently substitute a model.\n\n**Standards prompt** (`Axis: Standards`) includes:\n\n- The full original reviewed-base SHA, full reviewed HEAD SHA, and immutable whole-PR diff command and commit list bound to both.\n- The list of standards-source files you found in step 3, **plus the smell baseline from step 3** pasted in full (the sub-agent has no other access to it).\n\n**Spec prompt** (`Axis: Spec`) includes:\n\n- The full original reviewed-base SHA, full reviewed HEAD SHA, and immutable whole-PR diff command and commit list bound to both.\n- The path or fetched contents of the spec, with line numbers so findings can quote them.\n\nAlways invoke the Spec sub-agent. When absence is verified in step 2, explicitly supply \"No spec available.\" and the full reviewed HEAD so it returns the authentic SHA-bound no-spec skeleton. An unlocated spec without confirmation is not verified absence; ask before dispatch. A delegated worker asks its parent for that confirmation rather than claiming absence.\n\nIf a sub-agent returns something that does not match the template (including a bare verdict with no `Checked:` list), report it verbatim under its axis, say so, and re-run that axis; do not reformat or re-derive findings.\n\n### 5. Aggregate\n\nPresent the two reports under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_).\n\nEnd with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent.\n\n## Why two axes\n\nA change can pass one axis and fail the other:\n\n- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**\n- Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.**\n\nReporting them separately stops one axis from masking the other.\n",{"name":5,"description":7},"main","9ca373de7213ce33ac1c383b5706b72feb82bac9","packages\u002Fpreset\u002Fskills\u002Fcode-review",1,"https:\u002F\u002Fgithub.com\u002Fnredd\u002Fpi-harness","https:\u002F\u002Fgithub.com\u002Fnredd","DV Infra & Methodology @ QCOM | Caltech '19","2026-11-15 12:27:17",{"source":8,"skillName":5,"commands":33,"prompt":43,"zipAvailable":44},[34,37,40],{"tool":35,"command":36},"npx","npx skills add nredd\u002Fpi-harness --skill code-review",{"tool":38,"command":39},"bunx","bunx skills add nredd\u002Fpi-harness --skill code-review",{"tool":41,"command":42},"pnpm","pnpm dlx skills add nredd\u002Fpi-harness --skill code-review","安装技能，技能地址：https:\u002F\u002Fgithub.com\u002Fnredd\u002Fpi-harness\u002Fblob\u002Fmain\u002Fpackages\u002Fpreset\u002Fskills\u002Fcode-review\u002FSKILL.md",true,[],[47,54,61],{"skillNo":48,"name":49,"nameZh":6,"description":50,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":51,"categories":52,"keywords":53,"publishedAt":19},"01M7F0CJ09TSN5H7H6QWHVYFJG","ship-issue","Address a GitHub issue in a dedicated git worktree -- implement, gate, obtain exact-HEAD reviews, open a PR, and hand protected merge ownership to the parent. Use when the user names an issue URL or number and wants it shipped.","https:\u002F\u002Fgithub.com\u002Fnredd\u002Fpi-harness\u002Fblob\u002Fmain\u002Fpackages\u002Fpreset\u002Fskills\u002Fship-issue\u002FSKILL.md",[],[],{"skillNo":55,"name":56,"nameZh":6,"description":57,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":58,"categories":59,"keywords":60,"publishedAt":19},"01M7F0CCGWM47A2796Q6FH8AV8","get-it-merged","Land a requested set of open PRs as a dependency-aware merge train: the parent reviews, arms protected auto-merge, watches each terminal outcome with a native monitor, and advances until the list is merged or genuinely blocked. Use when multiple PRs are open in one repo and the user wants them merged.","https:\u002F\u002Fgithub.com\u002Fnredd\u002Fpi-harness\u002Fblob\u002Fmain\u002Fpackages\u002Fpreset\u002Fskills\u002Fget-it-merged\u002FSKILL.md",[],[],{"skillNo":62,"name":63,"nameZh":6,"description":64,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":65,"categories":66,"keywords":67,"publishedAt":19},"01M7F0C8KTXWQ463FR653N783M","coding-like-redd","Redd's Python and Rust coding standards -- tooling (uv\u002Fruff\u002Fty; cargo\u002Fclippy\u002Fnextest), code style rules, error\u002Flogging\u002Fsubprocess conventions, and required-project-file templates (including Makefiles). Load whenever writing, reviewing, editing, or scaffolding Python or Rust code, or asked about Redd's coding standards, in ANY project.","https:\u002F\u002Fgithub.com\u002Fnredd\u002Fpi-harness\u002Fblob\u002Fmain\u002Fpackages\u002Fpreset\u002Fskills\u002Fcoding-like-redd\u002FSKILL.md",[],[]]