[{"data":1,"prerenderedAt":-1},["ShallowReactive",2],{"skill:01M756YMET3MADEJKEK6JQ5B8G":3,"skill-same:01M756YMET3MADEJKEK6JQ5B8G":46},{"skillNo":4,"name":5,"nameZh":6,"description":7,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":6,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":15,"categories":16,"keywords":17,"publishedAt":18,"linkOnly":19,"markdownContent":20,"markdownBody":21,"frontMatter":22,"refName":24,"commitSha":25,"skillDirectory":26,"forksCount":27,"repositoryHtmlUrl":28,"repositoryHomepageUrl":29,"ownerHtmlUrl":30,"ownerBlogUrl":6,"ownerDescription":6,"updatedAt":31,"install":32,"resources":45},"01M756YMET3MADEJKEK6JQ5B8G","merge-ready",null,"Decide whether a change is ready to merge, and review it to that bar. Use when reviewing a pull request or deciding whether to merge a branch, to check that the change does what it claims, is DRY, clean, idiomatic and maintainable, has a solid test base that would actually catch a regression, holds up on performance, and ships with the right docs.","lanorme\u002Flanorme","lanorme","https:\u002F\u002Favatars.githubusercontent.com\u002Fu\u002F289880483?v=4","01M756YE5P1Y6R0SE0SHBC7ZPF","01M756YE6QHCA3SRDKNSHVPSYF",3,"MIT","https:\u002F\u002Fgithub.com\u002Flanorme\u002Flanorme\u002Fblob\u002Fmain\u002F.claude\u002Fskills\u002Fmerge-ready\u002FSKILL.md",[],[],"2026-11-12 13:55:43",false,"---\nname: merge-ready\ndescription: Decide whether a change is ready to merge, and review it to that bar. Use when reviewing a pull request or deciding whether to merge a branch, to check that the change does what it claims, is DRY, clean, idiomatic and maintainable, has a solid test base that would actually catch a regression, holds up on performance, and ships with the right docs.\nlicense: MIT\nmetadata:\n  project: lanorme\n---\n\n# Is it merge-ready?\n\nA change is merge-ready when it would survive being depended on. Review it against\nevery item below. A \"no\" on any item is a request for changes, not a merge.\n\n## Run it first\n\nBefore reading code, reproduce the claim and run the gates on the **merge result**\n(the branch rebased on the current `main`, not the branch in isolation):\n\n```\nscripts\u002Fcheck.sh        # unit tests, dogfood (lanorme check .), build\n```\n\nIf the gates are red, stop there. If green, review the substance.\n\n## The bar\n\n1. **It does what it says.** The diff delivers the stated purpose, and you\n   confirmed it by running it rather than by reading it. The description matches\n   the change.\n2. **It is correct.** Edge cases are handled: empty input, a missing path, the\n   boundary values. Behaviour next to the change does not regress.\n3. **It is DRY.** No logic duplicated from elsewhere; shared helpers are reused.\n   `DRY-001` and `SIMILAR-001` stay green.\n4. **It is clean and idiomatic.** It reads like the code around it: naming,\n   structure, and patterns match. No dead code, no commented-out code, no debug\n   prints. It passes LaNorme on itself.\n5. **It is maintainable.** Within the house limits for size, complexity, and\n   parameters. A new reader can follow it, and any non-obvious decision carries a\n   short why.\n6. **The tests are solid, not decorative.** This is where most changes are weak:\n   - Every test would fail if the code under it broke. Confirm one by mentally\n     breaking the code and checking the test would catch it.\n   - Real assertions on behaviour and values, never \"it ran without raising\".\n   - Arrange, Act, Assert, with shared setup (the repo dogfoods `AAA-001` and\n     `AAA-002`).\n   - Positive and negative cases, the boundary values, and the specific bug this\n     change fixes, locked as a regression. Every new branch is exercised.\n   - Line coverage is not the goal; covering the behaviour is.\n7. **It holds up on performance.** The hot path is not made slower; measure it\n   when the change touches one. New work is bounded and its cost is understood.\n   A detector or heuristic was measured on a corpus, not asserted.\n8. **It ships its docs.** A `CHANGELOG` entry for anything a user notices; the\n   rule reference and the README tables updated when a rule or flag changed; no\n   doc drift.\n9. **The scope and history are clean.** Focused on one thing. No stray or scratch\n   files. Rebased on the current `main`, mergeable, CI green. The commits are\n   coherent and the original author is preserved.\n10. **It is safe.** No new secret, no dangerous call, no widening of the attack\n    surface that the change did not set out to make.\n\n## The decision\n\nMerge only when every item holds. When one fails, request the change with the\nexact fix and re-review the result. If you strengthen a weak test base yourself\nbefore merging, say so on the pull request so the record is honest.\n","# Is it merge-ready?\n\nA change is merge-ready when it would survive being depended on. Review it against\nevery item below. A \"no\" on any item is a request for changes, not a merge.\n\n## Run it first\n\nBefore reading code, reproduce the claim and run the gates on the **merge result**\n(the branch rebased on the current `main`, not the branch in isolation):\n\n```\nscripts\u002Fcheck.sh        # unit tests, dogfood (lanorme check .), build\n```\n\nIf the gates are red, stop there. If green, review the substance.\n\n## The bar\n\n1. **It does what it says.** The diff delivers the stated purpose, and you\n   confirmed it by running it rather than by reading it. The description matches\n   the change.\n2. **It is correct.** Edge cases are handled: empty input, a missing path, the\n   boundary values. Behaviour next to the change does not regress.\n3. **It is DRY.** No logic duplicated from elsewhere; shared helpers are reused.\n   `DRY-001` and `SIMILAR-001` stay green.\n4. **It is clean and idiomatic.** It reads like the code around it: naming,\n   structure, and patterns match. No dead code, no commented-out code, no debug\n   prints. It passes LaNorme on itself.\n5. **It is maintainable.** Within the house limits for size, complexity, and\n   parameters. A new reader can follow it, and any non-obvious decision carries a\n   short why.\n6. **The tests are solid, not decorative.** This is where most changes are weak:\n   - Every test would fail if the code under it broke. Confirm one by mentally\n     breaking the code and checking the test would catch it.\n   - Real assertions on behaviour and values, never \"it ran without raising\".\n   - Arrange, Act, Assert, with shared setup (the repo dogfoods `AAA-001` and\n     `AAA-002`).\n   - Positive and negative cases, the boundary values, and the specific bug this\n     change fixes, locked as a regression. Every new branch is exercised.\n   - Line coverage is not the goal; covering the behaviour is.\n7. **It holds up on performance.** The hot path is not made slower; measure it\n   when the change touches one. New work is bounded and its cost is understood.\n   A detector or heuristic was measured on a corpus, not asserted.\n8. **It ships its docs.** A `CHANGELOG` entry for anything a user notices; the\n   rule reference and the README tables updated when a rule or flag changed; no\n   doc drift.\n9. **The scope and history are clean.** Focused on one thing. No stray or scratch\n   files. Rebased on the current `main`, mergeable, CI green. The commits are\n   coherent and the original author is preserved.\n10. **It is safe.** No new secret, no dangerous call, no widening of the attack\n    surface that the change did not set out to make.\n\n## The decision\n\nMerge only when every item holds. When one fails, request the change with the\nexact fix and re-review the result. If you strengthen a weak test base yourself\nbefore merging, say so on the pull request so the record is honest.\n",{"name":5,"license":14,"metadata":23,"description":7},{"project":9},"main","49cf2b150731b9b2f20c63a00f55911ec76efd07",".claude\u002Fskills\u002Fmerge-ready",6,"https:\u002F\u002Fgithub.com\u002Flanorme\u002Flanorme","https:\u002F\u002Flanorme.github.io\u002Flanorme\u002F","https:\u002F\u002Fgithub.com\u002Flanorme","2026-11-14 08:19:23",{"source":8,"skillName":5,"commands":33,"prompt":43,"zipAvailable":44},[34,37,40],{"tool":35,"command":36},"npx","npx skills add lanorme\u002Flanorme --skill merge-ready",{"tool":38,"command":39},"bunx","bunx skills add lanorme\u002Flanorme --skill merge-ready",{"tool":41,"command":42},"pnpm","pnpm dlx skills add lanorme\u002Flanorme --skill merge-ready","安装技能，技能地址：https:\u002F\u002Fgithub.com\u002Flanorme\u002Flanorme\u002Fblob\u002Fmain\u002F.claude\u002Fskills\u002Fmerge-ready\u002FSKILL.md",true,[],[47,54,61,68,74,80],{"skillNo":48,"name":49,"nameZh":6,"description":50,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":6,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":51,"categories":52,"keywords":53,"publishedAt":18},"01M756ZM21V76B0ZBFZAY82KF1","valid-minimal","A minimal valid skill used as a parser fixture.","https:\u002F\u002Fgithub.com\u002Flanorme\u002Flanorme\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Fvalid-minimal\u002FSKILL.md",[],[],{"skillNo":55,"name":56,"nameZh":6,"description":57,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":6,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":58,"categories":59,"keywords":60,"publishedAt":18},"01M756ZHMJ94FRJ1JG09KY46DN","valid-links","A valid skill that links to a bundled reference file.","https:\u002F\u002Fgithub.com\u002Flanorme\u002Flanorme\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Fvalid-links\u002FSKILL.md",[],[],{"skillNo":62,"name":63,"nameZh":6,"description":64,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":6,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":65,"categories":66,"keywords":67,"publishedAt":18},"01M756ZE4AK413FAJFMNGFA9CZ","valid-folded","A valid skill whose description is a folded block scalar spanning multiple lines, to make sure the parser does not call it empty.","https:\u002F\u002Fgithub.com\u002Flanorme\u002Flanorme\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Fvalid-folded\u002FSKILL.md",[],[],{"skillNo":69,"name":70,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":6,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":71,"categories":72,"keywords":73,"publishedAt":18},"01M756ZCXB36P5G924X31E7Y0T","unterminated","https:\u002F\u002Fgithub.com\u002Flanorme\u002Flanorme\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Funterminated\u002FSKILL.md",[],[],{"skillNo":75,"name":76,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":6,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":77,"categories":78,"keywords":79,"publishedAt":18},"01M756ZBMET5CDBKZB1XQRNA0J","missing-desc","https:\u002F\u002Fgithub.com\u002Flanorme\u002Flanorme\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Fmissing-desc\u002FSKILL.md",[],[],{"skillNo":81,"name":82,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":6,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":83,"categories":84,"keywords":85,"publishedAt":18},"01M756ZA64EC9QA4KCY33GQB7E","invalid-no-frontmatter","https:\u002F\u002Fgithub.com\u002Flanorme\u002Flanorme\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Finvalid-no-frontmatter\u002FSKILL.md",[],[]]